Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor out conservative_is_privately_uninhabited #103454

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Factor out conservative_is_privately_uninhabited #103454

merged 3 commits into from
Nov 21, 2022

Conversation

camsteffen
Copy link
Contributor

After #102660 there is no more need for conservative_is_privately_uninhabited.

r? @oli-obk

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 23, 2022
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2022
@camsteffen camsteffen force-pushed the remove-conservatively-uninhabited branch from 2eb033e to b6e6314 Compare October 24, 2022 00:11
@camsteffen camsteffen changed the title Remove conservatively uninhabited Factor out conservative_is_privately_uninhabited Oct 24, 2022
@camsteffen camsteffen force-pushed the remove-conservatively-uninhabited branch from b6e6314 to 1b7eb73 Compare October 24, 2022 00:23
@camsteffen
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 25, 2022
@bors
Copy link
Contributor

bors commented Oct 25, 2022

⌛ Trying commit 1b7eb73a059e04a0a8c4e88855ab8e12d2f664a3 with merge 523265f2409bfcee2b3fe7157a528e09edd9123e...

@bors
Copy link
Contributor

bors commented Oct 25, 2022

☀️ Try build successful - checks-actions
Build commit: 523265f2409bfcee2b3fe7157a528e09edd9123e (523265f2409bfcee2b3fe7157a528e09edd9123e)

@rust-timer
Copy link
Collaborator

Queued 523265f2409bfcee2b3fe7157a528e09edd9123e with parent 758f196, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (523265f2409bfcee2b3fe7157a528e09edd9123e): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.3% [0.2%, 2.4%] 2
Improvements ✅
(primary)		 -0.4% [-0.5%, -0.2%] 17
Improvements ✅
(secondary)		 -0.7% [-0.7%, -0.7%] 2
All ❌✅ (primary) -0.4% [-0.5%, -0.2%] 17

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.8% [2.5%, 3.1%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.4% [-5.4%, -3.6%] 3
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Oct 25, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Nov 8, 2022

r=me with tests reinstated and comments updated (maybe just make them links to the issues?)

@bors delegate+

@bors
Copy link
Contributor

bors commented Nov 8, 2022

✌️ @camsteffen can now approve this pull request

@camsteffen camsteffen force-pushed the remove-conservatively-uninhabited branch from 1b7eb73 to 9239cde Compare November 17, 2022 23:51
@camsteffen
Copy link
Contributor Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Nov 18, 2022

📌 Commit 9239cdea9d481531ffc9a2eee1680716ce20fcf2 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2022
@bors
Copy link
Contributor

bors commented Nov 19, 2022

⌛ Testing commit 9239cdea9d481531ffc9a2eee1680716ce20fcf2 with merge b307b17b29af3dc4e7db9b41f8a6e80c9a394221...

@bors
Copy link
Contributor

bors commented Nov 19, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 19, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camsteffen camsteffen force-pushed the remove-conservatively-uninhabited branch from 9239cde to cc8dddb Compare November 21, 2022 01:10
@camsteffen
Copy link
Contributor Author

The failed test was just removed in #104571 so I probably just need a rebase.

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Nov 21, 2022

📌 Commit cc8dddb has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 21, 2022
@bors
Copy link
Contributor

bors commented Nov 21, 2022

⌛ Testing commit cc8dddb with merge 736c675...

@bors
Copy link
Contributor

bors commented Nov 21, 2022

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 736c675 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 21, 2022
@bors bors merged commit 736c675 into rust-lang:master Nov 21, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 21, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (736c675): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.9%, -0.2%] 22
Improvements ✅
(secondary)		 -0.7% [-0.7%, -0.7%] 2
All ❌✅ (primary) -0.4% [-0.9%, -0.2%] 22

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.1% [0.9%, 5.2%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.6% [-3.4%, -0.5%] 4
Improvements ✅
(secondary)		 -3.4% [-3.4%, -3.4%] 1
All ❌✅ (primary) -0.1% [-3.4%, 5.2%] 6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.0% [-2.1%, -2.0%] 3
All ❌✅ (primary) - - 0

@rustbot rustbot removed the perf-regression Performance regression. label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
7 participants
@camsteffen @rustbot @rust-timer @bors @oli-obk @rust-log-analyzer @rust-highfive